Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sv-disabled attribute #33

Closed
wants to merge 2 commits into from
Closed

Add sv-disabled attribute #33

wants to merge 2 commits into from

Conversation

dmackerman
Copy link

Not sure if this is horribly inefficient, but it works. You can pass in an expression into sv-disabled and the drag events will be disabled.

Example:

<div sv-root sv-part="goals.allGoals" sv-disabled="goals.sortEnabled" sv-on-sort="goals.onGoalSort($item, $partFrom, $partTo, $indexFrom, $indexTo)">
    <div sv-placeholder class="ks-reorder-placeholder"></div>
    <div sv-element>Something</div>
</div>

Also general code sanity cleanup, spacing - done automatically by my formatter. Can remove that if you want!

@jsancho
Copy link

jsancho commented Sep 4, 2015

hi @dmackerman thanks for this, spot on with what I was looking for.
I'm not the repo owner but general etiquette is that you should respect the original spacing and indentation. It's quite cumbersome to go over your specific changes otherwise.
ta!

@dmackerman dmackerman mentioned this pull request Sep 18, 2015
Open
team-infonet pushed a commit to team-infonet/angular-sortable-view that referenced this pull request Dec 17, 2015
re-indented @dmackermans pr:Add sv-disabled attribute (kamilkp#33)
100d50d
@team-infonet team-infonet mentioned this pull request Dec 17, 2015
Open
@kamilkp kamilkp closed this Jan 13, 2016
@caiocpricci2 caiocpricci2 mentioned this pull request Jun 21, 2016
Closed
@caiocpricci2
Copy link

Recreated this pul request keeping the code style and added a new sv-element-draggable option to disable a single element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmackerman @jsancho @caiocpricci2 @kamilkp